Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDNative: merge API structs, bump version of merged structs. #39183

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 31, 2020

Merge all core API functions from the old incompatible structs to the new single "Core API 2.0" and extension API functions with multiple sub-versions to the new single structs, bump version of the new structs, as was suggested in #39064.

@akien-mga
Copy link
Member

CC @godotengine/gdnative

Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of this, my only remark is that I would sync the major version number up with Godot, so instead of setting it to 2, set it to 4.

@bruvzg
Copy link
Member Author

bruvzg commented Jun 11, 2020

so instead of setting it to 2, set it to 4.

Changed it to 4.

@akien-mga akien-mga merged commit b5dfe45 into godotengine:master Jun 15, 2020
@akien-mga
Copy link
Member

Thanks!

@Anutrix
Copy link
Contributor

Anutrix commented Jun 16, 2020

This seems like a big update to GDNative. More explanation regarding this would be nice. Something like an article on the main site or on a periodically updated Release/Dev Notes page on docs site.

@akien-mga
Copy link
Member

This is pre-alpha, compatibility breaking changes to make things match the pre-alpha, compatibility broken master branch. Not really news worthy. There will be articles when there are things to talk about for sure, and that will involve the merge of the GDNative API structs, but for now it's not very useful to know about it when it's a year away from being released and usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants