-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDNative: merge API structs, bump version of merged structs. #39183
Conversation
09213ec
to
5307272
Compare
CC @godotengine/gdnative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan of this, my only remark is that I would sync the major version number up with Godot, so instead of setting it to 2, set it to 4.
5307272
to
c3e615e
Compare
Changed it to 4. |
Thanks! |
This seems like a big update to GDNative. More explanation regarding this would be nice. Something like an article on the main site or on a periodically updated Release/Dev Notes page on docs site. |
This is pre-alpha, compatibility breaking changes to make things match the pre-alpha, compatibility broken |
Merge all core API functions from the old incompatible structs to the new single "Core API 2.0" and extension API functions with multiple sub-versions to the new single structs, bump version of the new structs, as was suggested in #39064.