Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility methods for writing files to gradle project directory #40167

Merged

Conversation

amanj120
Copy link
Contributor

@amanj120 amanj120 commented Jul 6, 2020

Added functions that will be used to store files inside the gradle project directory

Forward port of #39864

@aaronfranke aaronfranke added this to the 4.0 milestone Jul 6, 2020
@amanj120 amanj120 closed this Jul 6, 2020
@amanj120 amanj120 deleted the forward_port_bundle_pr_saving_files branch July 6, 2020 19:53
@amanj120 amanj120 restored the forward_port_bundle_pr_saving_files branch July 6, 2020 19:54
@amanj120
Copy link
Contributor Author

amanj120 commented Jul 6, 2020

Will need to merge with the 3.2 branch later.

@amanj120 amanj120 reopened this Jul 6, 2020
@amanj120 amanj120 force-pushed the forward_port_bundle_pr_saving_files branch from b47d0b3 to 67c79f1 Compare July 7, 2020 18:25
@m4gr3d m4gr3d self-requested a review July 7, 2020 19:22
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m4gr3d m4gr3d added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 7, 2020
@m4gr3d m4gr3d requested a review from akien-mga July 7, 2020 19:33
@amanj120 amanj120 changed the title Forward port of #39864 Forward port of #39864: Utility methods for writing files to Gradle project Jul 7, 2020
@akien-mga akien-mga changed the title Forward port of #39864: Utility methods for writing files to Gradle project Utility methods for writing files to gradle project directory Jul 8, 2020
@akien-mga
Copy link
Member

@amanj120 FYI, the email used to author your commit (see https://github.com/godotengine/godot/commit/67c79f197690df71358b6f31653a05c554aa7e49.patch) is not affiliated to your @amanj120 GitHub account. It's not a problem for Git nor GitHub, but in case you want to reclaim ownership of the commit to your GitHub account, you can add this commit as secondary email in your GitHub settings.

@amanj120 amanj120 force-pushed the forward_port_bundle_pr_saving_files branch from 31e6ac3 to 78e0039 Compare July 9, 2020 17:57
@akien-mga akien-mga merged commit f67b658 into godotengine:master Jul 10, 2020
@akien-mga
Copy link
Member

Thanks!

@amanj120 amanj120 deleted the forward_port_bundle_pr_saving_files branch July 10, 2020 13:15
@m4gr3d m4gr3d removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants