Use a power-of-two value for Primary Grid Steps in the 3D editor #43754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the 2D editor default behavior. Powers of two are usually better for grid divisions as they are often used in level design.
Calinou
added
cherrypick:3.x
aaronfranke
approved these changes
Nov 21, 2020
There was a problem hiding this comment.
Makes sense, I support this change. The only reason it was set to 10 before is because that was the existing behavior.
As a coincidental benefit, since 8*8*8*8 is 4096, the practical limit for FPS games (4096m) falls on a primary grid line. Here's what that looks like (and if it was allowed to change size once more, it would fall on another primary line):
akien-mga
approved these changes
Nov 23, 2020
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the 2D editor default behavior.
Powers of two are usually better for grid divisions as they are often used in level design.