Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for numeric XML entities to XMLParser #45914

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Add support for numeric XML entities to XMLParser #45914

merged 1 commit into from
Feb 24, 2021

Conversation

HenryWConklin
Copy link
Contributor

  • Add support for decimal numeric entities to String::xml_unescape
  • Add more error checks to String::xml_unescape
  • Refactor XMLParser to use String::xml_unescape instead of an internal
    implementation

Fixes #45841

@HenryWConklin HenryWConklin force-pushed the 45841-xml-entities branch 5 times, most recently from 41d9216 to 01e1988 Compare February 12, 2021 03:04
@HenryWConklin
Copy link
Contributor Author

Is there a good command to run formatting as a precommit hook or something?
Also, I got an error for an unused function on one of the checks. Is there a flag I can set to get that error on my local build?

@akien-mga
Copy link
Member

Is there a good command to run formatting as a precommit hook or something?

Yes, you can run clang-format locally or as a pre-commit hook, see:
https://docs.godotengine.org/en/latest/community/contributing/code_style_guidelines.html

Also, I got an error for an unused function on one of the checks. Is there a flag I can set to get that error on my local build?

You can build with dev=yes (alias for verbose=yes warnings=extra werror=yes), but note that some warnings are compiler specific so you might not always reproduce the CI results 100% (but code should in theory be warning free on all compilers).

@HenryWConklin
Add support for numeric XML entities to XMLParser
c6a911f 
* Add support for decimal numeric entities to String::xml_unescape
* Add more error checks to String::xml_unescape
* Refactor XMLParser to use String::xml_unescape instead of an internal
implementation
@akien-mga akien-mga added this to the 4.0 milestone Feb 24, 2021
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 24, 2021
@akien-mga akien-mga merged commit 5a10f52 into godotengine:master Feb 24, 2021
@akien-mga
Copy link
Member

Thanks!

I think this might be worth cherry-picking for 3.2 though I'd probably wait for after 3.2.4 is released since we're already at RC 3 stage.

@HenryWConklin HenryWConklin mentioned this pull request Apr 17, 2021
Merged
@akien-mga
Copy link
Member

Cherry-picked via #47978.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 3, 2021
@kleonc kleonc mentioned this pull request Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

get_node_data returns a string with XML entities for e.g. '
3 participants
@HenryWConklin @akien-mga @YeldhamDev