Add support for numeric XML entities to XMLParser #47978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryWConklin
force-pushed
the
3.x-xml-numeric-entities
branch
from
e764dd1
to
5e9b2c8
Compare
* Add support for decimal numeric entities to String::xml_unescape * Add more error checks to String::xml_unescape * Refactor XMLParser to use String::xml_unescape instead of an internal implementation
akien-mga
force-pushed
the
3.x-xml-numeric-entities
branch
from
5e9b2c8
to
a28beb3
Compare
akien-mga
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Thanks for the backport and for taking the time to build a fallback for the testing framework we didn't have in 3.x :)
I pushed a rebase to solve merge conflicts and do a couple fixes:
- Replaced a few
char32_twithCharType. - Made sure that
XMLParsermembers are properly initialized so that the removal ofclose()in the constructor doesn't leave members with garbage data. - Style fixes now that we backported style changes from
master.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation
Cherry picked from master to fix conflicts with tests and use wchar_t/CharType instead of char32_t
Master MR: #45914