Fix Multi-Threaded Physics 2D crashes #48001
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29369, prevents crash in #29364 (but there are many other errors in log), possible fix for #35017 and #47489
I know I didn't add this to master first, but all test MRPs are for previous versions and privately I need this for 3.x first too.
I need some guidance how to rework this fix - I'm not sure if it's better to create separate data structures (as I did in
map_mt.h
) and replace them in critical places (area_2d_sw.h
,area_2d_sw.cpp
) or directly change existing structures as I did inself_list.h
(maybe with addition of some directives or template arguments).Also I'll appreciate any help testing this.