-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed conflict between tracks have same name different type in the AnimationTree cache #49411
fixed conflict between tracks have same name different type in the AnimationTree cache #49411
Conversation
c86f978
to
6362ed9
Compare
6362ed9
to
3820709
Compare
Self considering. I thought it was fine to cache MethodTrack and AudioTrack separately. However, currently, for Transform3D, Value, and Bezier, the changes are stored in the TrackCache in each TrackType without blending. To solve #49431, we need a way to convert, blend and combine them into one in the cache. |
f02fb9e
to
60ef0c6
Compare
For example,
and
will be blended, but
will not be blended. The above case can be seen in the demo project. If you want to solve the matching problem, we will need to do a huge refactoring. Currently, we can't tell from the subpath name "x" whether it is a |
60ef0c6
to
4f63e96
Compare
a420bd4
to
0eb1f6b
Compare
0eb1f6b
to
d1e1f1d
Compare
081b6df
to
6a55f46
Compare
ea2cf87
to
e58a8a7
Compare
Some methods has been outdated; superseded by #56902. |
I managed this in #56902, but reduz is not that positive about retargeting at least for 4.0, so I don't know if it will be merged by 4.0 or not. |
562278a
to
7ccee00
Compare
7ccee00
to
ccf0bbb
Compare
Salvaged and rebased. |
ccf0bbb
to
63d603d
Compare
d1ccf7d
to
7018215
Compare
7018215
to
34f3641
Compare
Closing this once since it is out of date. The inability to blend BezierTrack and ValueTrack can be made a documentation issue, but I think it needs to be taken care of in cases of path conflicts such as AudioTrack and MethodTrack. |
Fixed #48526.
Fixed #43848.
An animation will no longer be stuck implicitly as long as the single animation is played in the animation.
However, when some tracks conflict in the one animation, or when blending animations of different track types that will set the same value, only the track with the later iteration order will be played, regardless of the blend value. For example, the blending ofValueTrack
andBezierTrack
is not yet working correctly (so it's been like that for a while). This may need to be fixed in the future. See #49431.ValueTrack
andBezierTrack
are can be blended by latest commit. Fixed #49431. (But BlendShape Track and TRS Track are not so.)