Fixing 2D moving platform logic #50314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriceci
force-pushed
the
fix-2d-moving-platform-4
branch
from
7d5f22c
to
fd428e0
Compare
fabriceci
force-pushed
the
fix-2d-moving-platform-4
branch
4 times, most recently
from
97fbd77
to
dc04101
Compare
akien-mga
reviewed
Jul 14, 2021
Fixing by applying the movement in two steps, first the platform movement, and then the body movement. Plus, add the platform movement when we are on_wall.
fabriceci
force-pushed
the
fix-2d-moving-platform-4
branch
from
dc04101
to
cee814e
Compare
akien-mga
approved these changes
Jul 15, 2021
|
Thanks! |
|
This has been merged (merge commit eb23e52) but GitHub didn't register it properly, so the PR still shows as open (and conflicting with itself). Let's wait a bit to see if GitHub catches up with this apparent oops it had when I merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0 version of #50166
Bugsquad edit: fixes #42765, fixes #40256, fixes #47366, fixes #50155, fixes #50167, fixes #27537