-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Backport the Time singleton from master #54056
Conversation
Thanks for this! I was able to workaround the need for the Time class by just passing on the responsibility (of converting timestamps and the offsets to human readable strings) to the underlying VCS plugin. But after this is merged, I can update the VCS interface to just require a timestamp and a timezone offset from the plugin and Godot handles the rest \o/ |
|
219707a
to
16f4c20
Compare
You could also include a cherry-pick of #54256 in this PR once the |
30c1afb
to
967b8f7
Compare
fa8e2d0
to
a9fe18a
Compare
Maybe add references to the |
a9fe18a
to
d117579
Compare
d117579
to
035a84f
Compare
Thanks! |
This PR backports the Time singleton from #49123. However, unlike that PR, this PR doesn't change the methods in the OS (_OS) singleton or use these methods internally, for the sake of preserving compatibility with 3.x projects.
This has the following use cases:
This was discussed with @ChronicallySerious on RocketChat, since he could make use of this class in the version control integration in Godot 3.5.