Focus current node after connecting #54071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be rebased, but also, shouldn't we bubble up the signal and connect to it in NodeDock instead of passing the reference and connecting it inside of another class? That doesn't look very idiomatic or even clear to read. Other than that, the issue is probably still valid and worth fixing. |
KoBeWi
force-pushed
the
infinite_unlimited_connections
branch
from
4403a58
to
fc0e503
Compare
YuriSizov
reviewed
Jun 12, 2023
KoBeWi
force-pushed
the
infinite_unlimited_connections
branch
from
fc0e503
to
d17c522
Compare
YuriSizov
approved these changes
Jun 12, 2023
YuriSizov
added
the
cherrypick:4.1
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21950
I changed ConnectionsDock constructor to take NodeDock instead of EditorNode, not sure why it was originally like that.