Replace threaded renderer particle function fail conditions with warnings #54965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansemrau
force-pushed
the
rem-particles-errors
branch
from
aa13701
to
22f887a
Compare
briansemrau
changed the title
|
Is this still relevant as of 4.0 RC 1? |
|
The linked issue is still reproducible, and this approach should still fix it. This isn't a critical issue, however. E 0:00:01:0602 particles_is_inactive: This function should never be used with threaded rendering, as it stalls the renderer.
<C++ Error> Condition "RenderingServerGlobals::threaded" is true. Returning: false
<C++ Source> servers/rendering/renderer_rd/storage_rd/particles_storage.cpp:1541 @ particles_is_inactive()Perhaps the GPUParticles design needs to be altered to not call these functions if possible, but I think demoting these errors to warnings is appropriate. |
|
Someone on the rendering team should check in on this issue some time. |
|
The linked issue has been closed by #76859. So I guess we can say this is superseded now. Thanks for your contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54964
These checks make no sense to me, as these functions don't do anything to stall anything.Nevermind, I forgot they get pushed through the command queue.