[MP] Fix variant serialization after variant size change. #64843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bit mask used for the type when compressing variants in the Multiplayer API became too small to represent all variant types. This commit expand the mask, which means we no longer have an extra bit in the "meta" byte we use to store encoding information. The extra bit was only used in case of booleans to store the value and since booleans do not require extra encoding information we use those 2 bits to store the value instead.
akien-mga
approved these changes
Aug 24, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bit mask used for the type when compressing variants in the Multiplayer API became too small to represent all variant types.
This commit expand the mask, which means we no longer have an extra bit in the "meta" byte we use to store encoding information.
The extra bit was only used in case of booleans to store the value and
since booleans do not require extra encoding information we use those 2 bits to store the value instead.
Closes #64263 (superseded)
Closes #64231