Remove override_selected_font_color property
#67888
Merged
+21
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Oct 26, 2022
|
Done for RichTextLabel. |
|
Is this something that we are okay breaking compatibility for this late in the release cycle? Paulb23's comment in #45301 (comment) makes me think that this might impact some users workflow |
Any compatibility breakage might impact some workflow, so it's about severity. This change is low impact, because default stays the same and |
mhilbrunner
approved these changes
Oct 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45301
Color(0, 0, 0, 0)(default) is now used to disable text selected color. If you want transparent selected font, you can just use another transparent color, so it's not a problem.