Remove methods in header removed in c7eb814 #74898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
c7eb814 missed these methods in the RichTextLabel's header Remove set_override_selected_font_color from rich_text_label.h Remove is_override_selected_font_color from rich_text_label.h c7eb814 missed these methods in the TextEdit's header Remove set_override_selected_font_color from text_edit.h Remove is_override_selected_font_color from text_edit.h
|
|
KoBeWi
approved these changes
Mar 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #67888
c7eb814 missed these methods in the RichTextLabel's header
Remove set_override_selected_font_color from rich_text_label.h
Remove is_override_selected_font_color from rich_text_label.h
c7eb814 missed these methods in the TextEdit's header
Remove set_override_selected_font_color from text_edit.h
Remove is_override_selected_font_color from text_edit.h
As it stands, without a source file, all these methods can accomplish in this state is erroring in linkage if used anyway. Noticed this on one of my PRs and was curious why I wasn't getting an intellisense error but got a linkage error, this prevents that strange case.