Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of mouse wheel switch in scene tabs #70800

Merged
merged 1 commit into from
May 31, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 1, 2023

Editor allows to switch scene tabs with mouse wheel since #47700
However, just like with #65302, 100% of the times I used this functionality it was by accident (and it happens surprisingly often).

This PR adds a interface/scene_tabs/change_tabs_with_mouse_wheel editor setting that disables this function. removes the "feature".

@KoBeWi KoBeWi added this to the 4.x milestone Jan 1, 2023
@KoBeWi KoBeWi requested a review from a team January 1, 2023 12:36
@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 1, 2023

From the RC discussion, I'd just make it activate with a modifier key, like Ctrl, but otherwise leave it on. Would be nice to hear from someone who actually uses this feature though.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 1, 2023

Modifier would make this much less discoverable.

@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 1, 2023

Modifier would make this much less discoverable.

I don't think the fact that you can use a mouse wheel over the tabbar is discoverable in the first place, unless by accident. I don't think many expect this to do anything. And if it's not rebindable, then the setting makes it hostile towards the user, i.e. "you either use it like this, or you can't use it at all".

@Calinou
Copy link
Member

Calinou commented Jan 1, 2023

I wouldn't require using a modifier to use the mouse wheel either, as the behavior then becomes inconsistent with other apps that support this (patched Chromium, some KDE apps like Dolphin, etc). These don't require a modifier to be used.

@YuriSizov
Copy link
Contributor

Should we make the setting disabled by default then? I don't see much demand for this feature, there was no request referenced in the original PR, and the chance to trigger it accidentally is evidently high.

My suggestion for the modifier key is to remove the accidental element without disabling the feature. If we don't want that solution, then disabling it by default is the only option.

@Calinou
Copy link
Member

Calinou commented Jan 1, 2023

Should we make the setting disabled by default then?

Settings that are disabled by default have poor discoverability – they might as well not exist 🙂

At this point, I would rather remove the feature entirely if you think it's activated accidentally too often. I personally don't rely on it often in Godot (but I do in web browsers).

@KoBeWi
Copy link
Member Author

KoBeWi commented May 31, 2023

I changed the PR to remove the feature entirely instead. It technically reverts #47700, but clean revert was not possible due to conflicts, so not sure if it counts 🤔

@KoBeWi KoBeWi changed the title Allow to disable mouse wheel switch in scene tabs Get rid of mouse wheel switch in scene tabs May 31, 2023
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the usability improvement and not because of technical review.

@akien-mga akien-mga modified the milestones: 4.x, 4.1 May 31, 2023
@akien-mga akien-mga merged commit 1634a2b into godotengine:master May 31, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants