Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LIGHT_IS_DIRECTIONAL built-in for spatial shaders #76290

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

JohanAR
Copy link
Contributor

@JohanAR JohanAR commented Apr 20, 2023

Also fixes INV_VIEW_MATRIX in light() function for forward+ and mobile renderers

Fixes #67256 and partially implements godotengine/godot-proposals#6534

bugsquad edit: Fixes: #76181

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

In the future, I would actually split this into two PRS (no need to do that now) as this fixes a bug and adds an enhancement. Sometimes we may want the bugfix, but need more time to discuss the enhancement and the bugfix shouldn't get blocked as we decide.

@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Add LIGHT_IS_DIRECTIONAL built-in for spatial shaders Add LIGHT_IS_DIRECTIONAL built-in for spatial shaders May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants