Enable the use of all supported builtins on the light shader #76977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manueldun
force-pushed
the
light-shader-builtins
branch
from
a946327
to
f9fbb28
Compare
clayjohn
reviewed
Jun 8, 2023
servers/rendering/renderer_rd/shaders/forward_mobile/scene_forward_mobile_inc.glsl
Outdated
Show resolved
Hide resolved
manueldun
force-pushed
the
light-shader-builtins
branch
from
f9fbb28
to
8f50fa9
Compare
clayjohn
reviewed
Jun 8, 2023
servers/rendering/renderer_rd/shaders/scene_forward_lights_inc.glsl
Outdated
Show resolved
Hide resolved
When using the light process in spatial shader, the built-ins work as spected, now they work in forward+, mobile and compatibility renderer.
manueldun
force-pushed
the
light-shader-builtins
branch
from
8f50fa9
to
e2321c2
Compare
|
Thanks! |
|
Can't get a clean cherry-pick because it touches code around #76290. It would probably be better to have a dedicated 4.0 PR if we want this fixed in there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #76556 and fix #76861
When using the light process in spatial shader the built ins work as spected, now they work in forward+, mobile and compatibility renderer.
It is worth noting that I created a define named DRAW_CALL_PUSH_CONSTANT in scene_forward_mobile_inc.glsl to differenciate between forward+ and mobile renderer in scene_forward_lights_inc.glsl