Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that GLES3 cached shader load is successful #77163

Merged
merged 1 commit into from
May 17, 2023

Conversation

ChibiDenDen
Copy link
Contributor

@ChibiDenDen ChibiDenDen commented May 17, 2023

Fixes #77136

Verified by corrupting the shader data using
variant_bytes.ptrw()[5] = 0;
right before loading.
Shader cache loading fails but the shader compilation kicks in and everything still works

@ChibiDenDen ChibiDenDen requested a review from a team as a code owner May 17, 2023 16:04
@Calinou Calinou added this to the 4.1 milestone May 17, 2023
@akien-mga akien-mga changed the title Verify gles3 cached shader load successful Verify that GLES3 cached shader load is successful May 17, 2023
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is exactly what I had in mind. Tested locally by switching between GPUs and can confirm this fixes the issue

@akien-mga akien-mga merged commit 72e98fc into godotengine:master May 17, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants