Fix minimum size growing but not shrinking #77568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For control in auto/smart mode, its minimum size may be related to the size of the parent container. Multiple consultations are required to determine the minimum size. If `data.minimum_size_valid` is still `false` after calling `get_combined_minimum_size()`. This usually means that consultations are still required.
Rindbee
commented
May 28, 2023
| if (data.minimum_size_cache != minsize) { | ||
| size_changed = true; | ||
| } | ||
| data.minimum_size_valid = true; // Reset to true anyway. |
There was a problem hiding this comment.
Ideally, update_minimum_size() would only be called when the minimum size has changed, but in reality the minimum size may not have changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For control in auto/smart mode, its minimum size may be related to the size of the parent container. Multiple consultations are required to determine the minimum size.
If
data.minimum_size_validis stillfalseafter callingget_combined_minimum_size(). This usually means that consultations are still required.Fix #74052. There may be a better solution.