Update the minimum size of Label if necessary when resizing #77573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably want to fix the spelling error in "Label". 😛 |
Rindbee
changed the title
Rindbee
force-pushed
the
update-minimum-size-if-necessary
branch
from
544d368
to
cc68dfe
Compare
Previously, the necessary call to update the minimum size was missing.
Rindbee
force-pushed
the
update-minimum-size-if-necessary
branch
from
cc68dfe
to
45ac7e3
Compare
YuriSizov
reviewed
May 29, 2023
| @@ -654,7 +654,10 @@ void Label::_notification(int p_what) { | |||
| } break; | |||
|
|
|||
| case NOTIFICATION_RESIZED: { | |||
| lines_dirty = true; | |||
| if (autowrap_mode != TextServer::AUTOWRAP_OFF || overrun_behavior != TextServer::OVERRUN_NO_TRIMMING) { | |||
There was a problem hiding this comment.
This feels wrong because at the end of _shape we already call update_minimum_size() but for the opposite checks. Are you sure it's here where we're supposed to fix it?
There was a problem hiding this comment.
For these modes and behaviors, a change in size may result in a change in the minimum size. The minimum height varies due to the size's width in these modes.
Lines 676 to 683 in 2f57da2
Under the opposite option, changing the size does not actually change the minimum size. Calling update_minimum_size() in _shape() does not seem necessary unless you just switched to these options.
|
Superseded by #77651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the necessary call to update the minimum size was missing.
Fixes #74052.
Supersedes #77568.