Make sure that data.last_minimum_size is consistent with get_combined_minimum_size() at the same time (reverted)
#77651
Conversation
|
I can understand what this PR does, but I didn't delve why it works. But it fixes the linked issue; I didn't test with any project though (yet). |
| @@ -1620,6 +1604,21 @@ void Control::update_minimum_size() { | |||
| return; | |||
| } | |||
|
|
|||
| Size2 minsize = get_combined_minimum_size(); | |||
There was a problem hiding this comment.
Ensuring that data.minimum_size_valid is changed from false to true only happens here.
Previously switched to false in update_minimum_size(), get_combined_minimum_size() may have been called multiple times before getting here. So the value of data.last_minimum_size may be unreliable, causing the necessary minimum_size_changed signal to not be emitted the second time the change actually occurs.
…ned_minimum_size()` at the same time Move the code for switching `data.minimum_size_valid` in `Control::update_minimum_size()` to `Control::_update_minimum_size()`, make sure to switch `data.minimum_size_valid` to `false` only before updating `data.last_minimum_size` , so that it will remain consistent with `get_combined_minimum_size()`.
Rindbee
force-pushed
the
fix-update-minimum-size
branch
from
31ea666
to
594852c
Compare
There was a problem hiding this comment.
I'm a bit concerned that we are now calling all this invalidation logic on visibility changes. The idea is fine, but it also signals to the owning window that controls have changed, multiple times, from every child of the node that has changed its visibility. At the moment, child_controls_changed has guards, so it's probably not going to making anything worse, but it's still a bit concerning.
|
Thanks! |
akien-mga
changed the title
data.last_minimum_size is consistent with get_combined_minimum_size() at the same timedata.last_minimum_size is consistent with get_combined_minimum_size() at the same time (reverted)
|
Reverted by #78009. |
Move the code for switching
data.minimum_size_validinControl::update_minimum_size()toControl::_update_minimum_size(), make sure to switchdata.minimum_size_validtofalseonly before updatingdata.last_minimum_size, so that it will remain consistent withget_combined_minimum_size().Fixes #74052.
Supersedes #77573. In the method connected to the
minimum_size_changedsignal, the result obtained by usingget_combined_minimum_size()is consistent withdata.last_minimum_size.Works fine with #77280.