Better support for unicode strings in TTR

[KoBeWi]

This string

godot/editor/plugins/editor_resource_tooltip_plugins.cpp

Line 109 in 4642448

Label *label = memnew(Label(vformat(TTR(U"Dimensions: %d × %d"), dimensions.x, dimensions.y)));

is not included in translation files, because U breaks the regex. The U is necessary to make the string parsed as unicode, because TTR converts it automatically to String.

I came up with as solution that involves the least changes - I just added an overload for TTR that takes char * and automatically interprets it as UTF-8. This probably means that all translated strings will now be parsed as unicode, not sure if brings any drawbacks (maybe it's slower than just making a String, idk).

[akien-mga]

If we go with this solution, it likely also needs an equivalent for TTRN and RTR.

[Calinou]

The U is necessary to make the string parsed as unicode

That reminds me, could we replace uses of String::utf8() in the codebase with U"string"? I've relied on the former exclusively so far.

[KoBeWi]

I think we could, at least for untranslated strings.

[bruvzg]

U"*" should be a bit faster since it's converted at the compile time.

I guess we can also add an extra case here to handle U instead - https://github.com/godotengine/godot-editor-l10n/blob/73d94c5089831177414c301bd671cf731694d89e/scripts/extract_editor.py#L52

[KoBeWi]

Ok I pushed other methods and also simplified the implementation.

[timothyqiu]

That reminds me, could we replace uses of String::utf8() in the codebase with U"string"? I've relied on the former exclusively so far.

Yeah, that's technically more portable. As U"string" is guaranteed to be UTF-32, while String::utf8() requires the source file to be UTF-8 encoded.

[akien-mga]

godotengine/godot-editor-l10n#6 should be sufficient to fix this I believe.

[KoBeWi]

Yeah, closing.