Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] C#: Print error when MethodBind call fails #79433

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[3.x] C#: Print error when MethodBind call fails #79433

merged 1 commit into from
Aug 2, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added this to the 3.x milestone Jul 13, 2023
@raulsntos raulsntos requested a review from a team July 13, 2023 17:43
RedworkDE
RedworkDE reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible to me, but I don't actually have a setup to build and test the 3.x mono version.

modules/mono/mono_gd/gd_mono_internals.cpp Show resolved Hide resolved
RedworkDE
RedworkDE approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@RedworkDE RedworkDE left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a 3.x version of #79342 (Now exists as #80072) to open the source files correctly on windows, works as expected otherwise.

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 2, 2023
@akien-mga akien-mga merged commit fa04a83 into godotengine:3.x Aug 2, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Aug 2, 2023
Closed
@raulsntos raulsntos deleted the 3x/dotnet/dont-ignore-call-error branch August 2, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@RedworkDE RedworkDE RedworkDE approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @akien-mga @RedworkDE