Fix nodes receiving mouse events in black bars of Window
#80334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously for InputEvents there was no distinction between Window-area and Viewport-area. This was problematic in cases where stretching was used and the Window contained black bars at the sides of the Viewport. This PR separates the area of Window and Viewport regarding InputEvents.
Sauermann
force-pushed
the
fix-window-out-of-viewport-events
branch
from
587d938
to
59c13fe
Compare
bruvzg
approved these changes
Aug 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for InputEvents there was no distinction between Window-area and Viewport-area.
This was problematic in cases where stretching was used and the Window contained black bars at the sides of the Viewport as in the linked issue. This PR separates the area of Window and Viewport regarding InputEvents.
resolve #80011
Updated: 2023-08-09: Fix merge conflict