Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate project_settings_changed signal #80450

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Deprecate project_settings_changed signal #80450

merged 1 commit into from
Aug 25, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 9, 2023 •
edited
Loading

Follow-up to #62038

  • deprecate project_settings_changed in EditorPlugin
  • remove the signal from EditorNode

Builds on top of #62038

@KoBeWi KoBeWi added this to the 4.x milestone Aug 9, 2023
@KoBeWi KoBeWi requested review from a team as code owners August 9, 2023 15:53
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Aug 9, 2023
@KoBeWi KoBeWi force-pushed the settings_freeze,_no_more_changes branch from a266198 to fca3ab5 Compare August 10, 2023 13:07
YuriSizov
YuriSizov approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, nice little clean-up!

@YuriSizov YuriSizov merged commit e21ded8 into godotengine:master Aug 25, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the settings_freeze,_no_more_changes branch August 25, 2023 13:18
@raulsntos raulsntos mentioned this pull request Aug 30, 2023
Merged
@YuriSizov YuriSizov mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@akien-mga akien-mga akien-mga approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @YuriSizov @akien-mga @AThousandShips