Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pressing save in Import Defaults not working #84291

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fix pressing save in Import Defaults not working #84291

merged 1 commit into from
Nov 1, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #84248

@Calinou Calinou added bug topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 1, 2023
@Calinou Calinou added this to the 4.2 milestone Nov 1, 2023
Calinou
Calinou approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

PS: Why do we have a Save button in that dialog in the first place? The usual approach in Godot is to save property changes automatically, but offer a way to undo/redo changes.

@jsjtxietian
Copy link
Contributor Author

Why do we have a Save button in that dialog in the first place?

I guess we have to ask reduz for that. Personally I think save property changes automatically is fine as .project file won't be too large.

@akien-mga akien-mga merged commit 8a403e7 into godotengine:master Nov 1, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the fix-import-default-save-failed branch November 1, 2023 14:40
@YuriSizov YuriSizov changed the title Fix press save in Import Defaults did not save the changed setting Fix pressing save in Import Defaults not working Nov 6, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

This is a regression from #80450, in 4.1 we still have the old signal and it should work fine. So a cherry-pick is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

After making changes to Project Settings, any changes are not saved to the project.godot file
4 participants
@jsjtxietian @akien-mga @YuriSizov @Calinou