Moved face_index field in 3D RayResult to end of struct
#82403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihe
force-pushed
the
ray-result-reordering
branch
from
b244258
to
f1a9d8b
Compare
dsnopek
approved these changes
Sep 26, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80444.
This moves the new
face_indexfield found inPhysicsDirectSpaceState3D::RayResult, also known/bound asPhysicsServer3DExtensionRayResult, which was introduced in #71233, to the end of the struct, thereby "fixing" the accidental GDExtension compatibility breakage that happened as a result of it being added in the middle of the struct.Note that while this is still technically a breaking change, since it still changes the size/layout of
RayResult, the only part of the GDExtension API that actually uses this isPhysicsDirectSpaceState3DExtension::_intersect_ray, which has you writing to that struct through a pointer, meaning only the field offsets have to be preserved between versions, which this PR should satisfy.