Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter nodes selection on bone rename notification #83149

Closed

Conversation

dpalais
Copy link
Contributor

@dpalais dpalais commented Oct 11, 2023

It seems this error appears ever since #79341 got merged. Since BoneAttachment3D is the only consumer of this notification, I made the find_children call more restrictive in its parameters.

Fixes #83148

@fire
Copy link
Member

fire commented Oct 11, 2023

How are you determining BoneAttachment3D is the only consumer of this notification?

@dpalais
Copy link
Contributor Author

dpalais commented Oct 11, 2023

How are you determining BoneAttachment3D is the only consumer of this notification?

I did a grep search in the Godot source code.

$ git grep _notify_skeleton_bones_renamed                                           
editor/import/post_import_plugin_skeleton_renamer.cpp:                  nd->callv("_notify_skeleton_bones_renamed", vargs);
scene/3d/bone_attachment_3d.cpp:void BoneAttachment3D::_notify_skeleton_bones_renamed(Node *p_base_scene, Skeleton3D *p_skeleton, Dictionary p_rename_map) {
scene/3d/bone_attachment_3d.cpp:        ClassDB::bind_method(D_METHOD("_notify_skeleton_bones_renamed"), &BoneAttachment3D::_notify_skeleton_bones_renamed);
scene/3d/bone_attachment_3d.h:  virtual void _notify_skeleton_bones_renamed(Node *p_base_scene, Skeleton3D *p_skeleton, Dictionary p_rename_map);

Alternatively doing a check that verifies if the node has such method might be preferable.

@akien-mga
Copy link
Member

Superseded by #83986 which should include this too. Thanks for the contribution!

@akien-mga akien-mga closed this Oct 26, 2023
@AThousandShips AThousandShips removed this from the 4.2 milestone Oct 26, 2023
@dpalais dpalais deleted the notify-boneattachment3d-only branch November 8, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor errors on import of a scene with a skeleton and a Bone Map resource
4 participants