Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assign with swizzle in shader not doing varying validation check #83830

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix assign with swizzle in shader not doing varying validation check #83830

merged 1 commit into from
Oct 25, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #83742

@jsjtxietian jsjtxietian requested a review from a team as a code owner October 23, 2023 09:55
@akien-mga akien-mga requested a review from a team October 23, 2023 10:03
@akien-mga akien-mga added this to the 4.2 milestone Oct 23, 2023
clayjohn
clayjohn approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and I tested locally to confirm that it works. The error appears in the editor as it should and it avoids the user being exposed to the full, internal shader error

@akien-mga akien-mga merged commit 9f49da2 into godotengine:master Oct 25, 2023
15 checks passed
@jsjtxietian jsjtxietian deleted the fix-varying-assign-swizzle-check branch October 25, 2023 08:39
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Trying to modify a varying from fragment shader crashes the editor
3 participants
@jsjtxietian @akien-mga @clayjohn