Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind _reset/_restore in AnimationMixer #85254

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 23, 2023

Sorry that I have missed to bind it.

Fixes #85232.

But #85233 still seems happen so it may be related by #84942 (comment) or others... (Will this fix that? #85233 (comment))

@TokageItLab TokageItLab added this to the 4.2 milestone Nov 23, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner November 23, 2023 01:43
@TokageItLab TokageItLab changed the title Bind _reset()/_restore() in AnimationPlayer Bind _reset()/_restore() in AnimationMixer Nov 23, 2023
@TokageItLab TokageItLab changed the title Bind _reset()/_restore() in AnimationMixer Bind _reset/_restore in AnimationMixer Nov 23, 2023
@TokageItLab TokageItLab force-pushed the bind-reset-animedit branch 2 times, most recently from 859723b to 10e9bde Compare November 23, 2023 08:51
@akien-mga akien-mga merged commit bb63963 into godotengine:master Nov 23, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the bind-reset-animedit branch February 14, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation window Edit -> Apply Reset fails because AnimationMixer::_reset is not exposed
2 participants