RenderingDevice: Fix uniform sets wrongly assumed to be bound #86522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Also seems to fix #86425 |
clayjohn
approved these changes
Jan 2, 2024
|
Thanks! |
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the former logic, the need to re-bind a uniform set at the graphics API level was determined solely on the format and the "survivavility" of the binding according to the relevant binding model. However, it was wrong in failing to realize that a uniform set that has still not been bound at the graphics API level has to be bound regardless any other consideration. EDIT: (Not to mention the check was broken whatsoever in the compute case.)
Fixes #86408.
Fixes #86400.
Fixes #86547.
Fixes #86425.