-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static body creation equivalent for all collision shape sibling creations #86627
Add static body creation equivalent for all collision shape sibling creations #86627
Conversation
4746b74
to
98febff
Compare
98febff
to
58473b9
Compare
I tested with a build artifact from this PR and a simple 2x2x2 BoxMesh. The "Static Body Child" options all work as expected and create StaticBody3D child node with a CollisionShape3D child node that has a ConvexPolygonShape3D resource. Now what does not seem to work as expected are the "Sibling" options. I would expect them to do the very same except for leaving out the StaticBody3D node and place the CollisionShape3D node as a sibling with the same ConvexPolygonShape3D resource as with the other options. The node creation and placement works but not the Shape3D resource creation. Not sure why but the sibling options all created ConcavePolygonShape3D for everything no matter what convex menu option is picked. I would expect them to create the same shape as the other convex options that work. |
58473b9
to
fa12df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem to work as expected now. I did not encounter any more issues.
… all static body options Apply suggestions from code review Co-Authored-By: A Thousand Ships <[email protected]>
e49a261
to
b84f66c
Compare
Thanks! |
Fix #86626
Just adds an option in the popup menu and handle it the same way it was handled for trimesh collision shapes