Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null check improvements #87370

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Null check improvements #87370

merged 1 commit into from
Jan 22, 2024

Conversation

AThousandShips
Copy link
Member

Some cases that slipped through review

@AThousandShips AThousandShips added this to the 4.3 milestone Jan 19, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner January 19, 2024 12:23
BastiaanOlij
BastiaanOlij approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YuriSizov YuriSizov merged commit f98e575 into godotengine:master Jan 22, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips AThousandShips deleted the null_additional branch January 22, 2024 19:47
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @YuriSizov @BastiaanOlij @akien-mga