Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextureRegionEditor::_pan_callback deferred called with only one argument #87771

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix TextureRegionEditor::_pan_callback deferred called with only one argument #87771

merged 1 commit into from
Feb 5, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #87703

@AThousandShips AThousandShips added this to the 4.3 milestone Jan 31, 2024
Calinou
Calinou approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

KoBeWi
KoBeWi approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but the fix is correct.

@akien-mga akien-mga merged commit 474d9b7 into godotengine:master Feb 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the region-mismatch branch February 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Error about deferred method call is printed when opening the TextureRegion editor
5 participants
@jsjtxietian @akien-mga @Calinou @KoBeWi @AThousandShips