Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XR] Fix binds for composition layer virtuals #90391

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[XR] Fix binds for composition layer virtuals #90391

merged 1 commit into from
Apr 8, 2024

Conversation

AThousandShips
Copy link
Member

As they are called with no arguments I assume the binds were invalid, likely copy-paste error

@AThousandShips AThousandShips added this to the 4.3 milestone Apr 8, 2024
@AThousandShips AThousandShips requested review from dsnopek and a team and removed request for dsnopek April 8, 2024 15:30
dsnopek
dsnopek approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! This was my mistake, sorry. :-/

This fix looks good to me!

@akien-mga akien-mga merged commit 0c6b5ef into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the xr_bind_fix branch April 8, 2024 16:44
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug topic:gdextension topic:xr
Projects
None yet
Milestone
4.3
3 participants
@AThousandShips @akien-mga @dsnopek