GDScript: Implement get_dependencies() (reverted)
#90860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser and analyzer now track the dependencies of the script and return the list when the resource loader ask for them. What is considered a dependency: - Any `preload()` call. - The base script this one extends. - Any identifier, including types, that refers to global scripts. - Any autoload singleton reference.
akien-mga
changed the title
get_dependencies()
akien-mga
approved these changes
Apr 29, 2024
|
Thanks! |
This was referenced May 8, 2024
akien-mga
changed the title
get_dependencies()get_dependencies() (reverted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser and analyzer now track the dependencies of the script and return the list when the resource loader ask for them.
What is considered a dependency:
preload()call.Fix #90643
P.S.: Initially I included the
@iconpath as a dependency, but I removed it since it's only relevant in the editor context. I don't think it's even accessible in a release build, so it shouldn't impact exporting the project.