-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scene] Add SceneStringNames::pressed
#91939
Conversation
SceneStringNames::pressed
25683ea
to
125323b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
It might be interesting to do some simple benchmark here. This will obviously reduce binary size (all similar changes do), but it can also minimally improve editor startup time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Another one to tackle in the same category would be toggled
. Not as frequent, but still:
$ rg 'connect.*"toggled"' | wc -l
71
125323b
to
ee79386
Compare
Thanks! |
Thank you! |
This is a very common name used across the codebase, unsure what the practical impact is but since there's about 700 uses of these I think it's a pretty good candidate to add, will check for other cases that are very common as well
Also considering:
FlatButton
228 casesfont_color
196 cases [Scene] AddSceneStringNames::font(_size/_color)
#92588Tree
191 casesLabel
165 casesid_pressed
161 cases [Scene] AddSceneStringNames::id_pressed
#91949panel
145 cases [Scene] AddSceneStringNames::panel
#91950font
132 cases [Scene] AddSceneStringNames::font(_size/_color)
#92588item_selected
131 cases [Scene] AddSceneStringNames::item_selected
#92638confirmed
124 cases [Scene] AddSceneStringNames::confirmed
#92639font_size
121 cases [Scene] AddSceneStringNames::font(_size/_color)
#92588text_changed
117 cases [Scene] AddSceneStringNames::text/value_changed
#92640value_changed
115 cases [Scene] AddSceneStringNames::text/value_changed
#92640separation
87 casesemit_signal
76 cases (forCoreStringNames
)toggled
72 cases [Scene] AddSceneStringNames::toggled
#92637Usenormal
72 cases (using already existingCoreStringNames::normal
)CoreStringNames::normal
in more places #91953accent_color
70 cases