Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scene] Add SceneStringNames::pressed #91939

Merged
merged 1 commit into from
May 14, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented May 14, 2024

This is a very common name used across the codebase, unsure what the practical impact is but since there's about 700 uses of these I think it's a pretty good candidate to add, will check for other cases that are very common as well

Also considering:

@AThousandShips AThousandShips added this to the 4.x milestone May 14, 2024
@AThousandShips AThousandShips requested review from a team as code owners May 14, 2024 09:27
@AThousandShips AThousandShips changed the title [Scene] Add SceneStringNames::pressed [Scene] Add SceneStringNames::pressed May 14, 2024
@AThousandShips AThousandShips removed request for a team May 14, 2024 10:49
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

It might be interesting to do some simple benchmark here. This will obviously reduce binary size (all similar changes do), but it can also minimally improve editor startup time.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Another one to tackle in the same category would be toggled. Not as frequent, but still:

$ rg 'connect.*"toggled"' | wc -l
71

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 14, 2024
@akien-mga akien-mga merged commit c0d2464 into godotengine:master May 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the pressed_sname branch May 14, 2024 16:12
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants