[Scene] Add SceneStringNames::toggled
#92637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! Already had this ready but hadn't opened the PR yet (far further down than more common cases, see #91939 for a comprehensive list of cases I'm working on) |
AThousandShips
changed the title
SceneStringName::toggledSceneStringNames::toggled
But far more than, for example, "theme_changed" which is already presented as SceneStringName. |
|
Yes but among the candidates for addition, like |
Chaosus
force-pushed
the
core_toggle_sname
branch
from
8b92e23
to
bbbc093
Compare
akien-mga
approved these changes
Jul 24, 2024
AThousandShips
approved these changes
Jul 24, 2024
|
Would be worth rebasing / checking if there are other occurrences to convert, then it can be merged. |
|
@akien-mga Seems to be no new "toggled" are introduced at the current time (db24ed4). After rebase and search:
|
|
I'd still push a rebase for good measure :) |
Chaosus
force-pushed
the
core_toggle_sname
branch
from
bbbc093
to
52889ab
Compare
|
@akien-mga Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A core enhancement similar to previous @AThousandShips commits, 😃