Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force canvas item update on oversampling change. #92731

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 3, 2024

Checks if canvas items were updated by viewport resize and forces update on oversampling change.

Fixes #91740

@bruvzg bruvzg added this to the 4.3 milestone Jun 3, 2024
@bruvzg bruvzg requested a review from a team as a code owner June 3, 2024 16:48
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Testing project: test_font_scale_change.zip

Before

Warning

Epilepsy warning: Flashing text is visible due to the bug this PR fixes.

simplescreenrecorder-2024-06-03_19.00.10.mp4

After (this PR)

simplescreenrecorder-2024-06-03_19.06.45.mp4

@akien-mga akien-mga merged commit 241d45d into godotengine:master Jun 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D Label smearing with ContentScaleSize
3 participants