Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font oversampling breaks rendering on Window node when game is resized. #76450

Closed
EMBYRDEV opened this issue Apr 25, 2023 · 7 comments · Fixed by #93490
Closed

Font oversampling breaks rendering on Window node when game is resized. #76450

EMBYRDEV opened this issue Apr 25, 2023 · 7 comments · Fixed by #93490
Assignees
Milestone

Comments

@EMBYRDEV
Copy link
Contributor

Godot version

4.0.2.stable

System information

Windows 11, Vulkan

Issue description

image

When font oversampling is enabled and the game is resized, the font rendering inside a window node breaks.

When the subwindow is resized the font rendering fixes itself.

Steps to reproduce

Download repo project, run test_ui.tscn, resize the main window.

Minimal reproduction project

UIScalingTest (2).zip

@Calinou
Copy link
Member

Calinou commented Oct 1, 2023

As a workaround, enable MSDF font rendering (you can do this in the Import dock, or in the Project Settings for the default project font). This will remove the need for font oversampling entirely.

@EMBYRDEV
Copy link
Contributor Author

EMBYRDEV commented Oct 2, 2023

As a workaround, enable MSDF font rendering (you can do this in the Import dock, or in the Project Settings for the default project font). This will remove the need for font oversampling entirely.

This does somewhat help but MSDF font rendering has some weird kerning issues I assume are being tracked elsewhere?

Before (correct):
image

After (misaligned 2nd 't' in testing among other small issues):
image

@nofuncoding
Copy link

same in 4.3.beta2
will this issue be solved?

@Calinou
Copy link
Member

Calinou commented Jun 22, 2024

will this issue be solved?

This requires #86022 to be merged to be fixed, which is a large PR that will require lots of testing. Godot 4.3 is in feature freeze, so that PR can only be merged in 4.4 at the earliest.

@bruvzg
Copy link
Member

bruvzg commented Jun 22, 2024

This should be fixed by #92731, but seems like subwindow title is still affected for some reason (text outside and inside subwindow seems to be fine).

@domdfcoding
Copy link

Is there a specific issue for the kerning problem with MSDF @EMBYRDEV mentioned? I'm seeing it too on 4.2.2 and the latest commit, although with my font the results aren't as bad.

@Calinou
Copy link
Member

Calinou commented Jul 21, 2024

Is there a specific issue for the kerning problem with MSDF @EMBYRDEV mentioned? I'm seeing it too on 4.2.2 and the latest commit, although with my font the results aren't as bad.

Please open a separate issue for this kerning issue with a minimal reproduction project attached. This was tangentially discussed in #90779, but that issue is best kept separate about font hinting specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants