Fix thread-use causing navigation mesh data corruption #93392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
changed the title
smix8
force-pushed
the
if_you_cant_behave_responsible_you_get_locked
branch
from
7eddad0
to
236a40a
Compare
Fixes navigation mesh data corruption caused by thread use that changed vertices or polygons while the navigation mesh was processed, e.g. by server sync or baking.
smix8
force-pushed
the
if_you_cant_behave_responsible_you_get_locked
branch
from
236a40a
to
fd727ab
Compare
RandomShaper
approved these changes
Jun 21, 2024
|
Thanks! |
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes navigation mesh data corruption caused by thread-use that changed vertices or polygons while the navigation mesh was processed, e.g. by server region sync, navmesh baking or user thread updates.
set_data()andget_data()in one call to avoid desync.sync()to region navigation mesh setter.Pairs with #93407
The NavigationMesh has a problematic legacy API where it is possible to set vertices and polygon indices that are not in sync due to both using different functions with no real validation.
When user-threads were manipulating the resource there was opportunity to read the resource while another thread changed the data in the middle. This was very common in large projects when users would reuse the same navigation mesh resource and started the next update as soon as they set the navigation mesh on a region, not knowing that it takes some time for the sync to happen.