-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix signal tooltip not leaving #93943
Conversation
The issue this fixes isn't specific to linux. The behavior was also messed up when not in single window mode as well, it wasn't changing when hovering over another item. This is also fixed by this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it impossible to hover over the tooltip, so I would prefer to fix this another way. Also, I'm not sure that you are fixing the real cause of the bug, and not its symptom.
The fact that Tree
elements are not individual controls (unlike the Inspector) of course makes using the tooltip less convenient: you need to first leave the Signals dock and hover over another signal again, rather than simply moving the cursor to another signal. But I think that it's a minor usability issue, not the cause of the bug with tooltip duplication in some cases.
In single window mode, hovering over the tooltip has no use at all (doesn't get input), so I feel like this feature needs some more time in this case (see #92545). I could have fixed it by storing a reference to the EditorHelpBitTooltip in the connections dock to prevent duplicates, but that feels like a workaround since this system is trying to subvert the existing tooltip system, and it wouldn't fix the other issues with it. Also I think that being able to get tooltips for different signals easily is more important than being able to click on links in the descriptions, since many signals don't have links and their full documentation can be opened to be able to follow the links anyway. |
I'm in favour of fixing this annoyance first, and then coming up with a way for the tooltip to be clickable later. #89058 did way too much at once, more than it was supposed to by its title. |
I'll take a look at this soon to see if I can come up with a better solution.
We could add a static variable to
Not only clickable links, but also the ability to scroll content. |
Personally I prefer the other PR, but either one is fine for now. The tooltips need fixing anyway. |
Superseded by #93967 (for now). |
Changes it to use the regular tooltip system.
It wasn't working since the tree doesn't emit
mouse_exit
signals whenever different items are hovered, and theEditorHelpBitTooltip
system expected that.This also affects the behavior when not in single window mode, it should be better.