Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix EditorHelpBitTooltip for Signals dock #93967

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jul 5, 2024

@dalexeev dalexeev force-pushed the editor-fix-help-bit-tooltip-for-signals branch from cf70be2 to ec2f935 Compare July 5, 2024 13:15
@akien-mga akien-mga requested a review from KoBeWi July 5, 2024 13:20
@kitbdev
Copy link
Contributor

kitbdev commented Jul 5, 2024

This does not fix the other issues with the tooltip.
In single window mode, the tooltip doesn't stay when hovered over and cannot be interacted with. #92382 isn't an issue in single window mode.
In not single window mode, the tooltip doesn't change when hovering over different items.

When in single window mode it is now the same and when not it has issues, so I still prefer #93943

Also are there any signals that have a description long enough to need scrolling functionality in the tooltip?

Edit: Maybe forwarding mouse inputs outside of the tooltip will fix some of the issues?

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a proper fix for #93698

Does not fix #92382, but IMO it's not a big problem. You can normally double-click before the tooltip appears.

@akien-mga
Copy link
Member

Overall I find that we're going in a somewhat hacky direction here, sidestepping the existing system for custom tooltips. If the current system isn't sufficient, we should look into improving it IMO.

But let's merge this approach for now to solve the main regression, and see how to deal with the other problems outlined by @kitbdev. I'll release 4.3 beta 3 soon so we should be able to get some testing done.

If we find more issues that aren't easy to address, I would suggest that we then consider #93943 instead to use the proper system in place, and work on improving the usability of the tooltip system for 4.4.

@akien-mga akien-mga merged commit 1cfcc04 into godotengine:master Jul 7, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the editor-fix-help-bit-tooltip-for-signals branch July 7, 2024 11:27
@dalexeev
Copy link
Member Author

dalexeev commented Jul 7, 2024

Overall I find that we're going in a somewhat hacky direction here, sidestepping the existing system for custom tooltips. If the current system isn't sufficient, we should look into improving it IMO.

Agree. See #89058 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal tooltip doesn't go away when moving mouse to another signal in single window mode
4 participants