Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when stopping empty animation player. #97760

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

EAinsley
Copy link
Contributor

@EAinsley EAinsley commented Oct 3, 2024

Fix #97714

Check if animation exists before get section start time.

Signed-off-by: Ainsley Su <[email protected]>
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM 👍
That said, it has made me aware that there's other edge cases we need to catch too, like what happens if you're playing an AnimationPlayer and then delete the animations while its still playing.

@EAinsley
Copy link
Contributor Author

EAinsley commented Oct 3, 2024

Good catch, LGTM 👍 That said, it has made me aware that there's other edge cases we need to catch too, like what happens if you're playing an AnimationPlayer and then delete the animations while its still playing.

That's why we need more tests for these edge cases.

@akien-mga akien-mga merged commit 5ccbf6e into godotengine:master Oct 3, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@EAinsley EAinsley deleted the fix#97714 branch October 4, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when stopping AnimationPlayer without current animation.
4 participants