Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Update Vulkan SDK install script. #97981

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[macOS] Update Vulkan SDK install script. #97981

merged 1 commit into from
Oct 8, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 8, 2024

Latest version of SDK switched from DMG to ZIP.

@bruvzg bruvzg added this to the 4.4 milestone Oct 8, 2024
@bruvzg bruvzg requested a review from a team as a code owner October 8, 2024 16:38
@AThousandShips

This comment was marked as resolved.

Sign in to view
AThousandShips
AThousandShips approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, and seems the previous intermittent issue might be caching related so should work going forward

@Repiteo Repiteo merged commit 4c4e673 into godotengine:master Oct 8, 2024
18 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 8, 2024

Thanks!

@Spartan322 Spartan322 mentioned this pull request Oct 9, 2024
Merged
@purefunctor purefunctor mentioned this pull request Oct 10, 2024
Open
ElonGaties referenced this pull request Oct 10, 2024
@avondersaar-uphold
[macOS] Update Vulkan SDK install script.
a2c29bd
@monxa monxa mentioned this pull request Oct 13, 2024
Merged
12 tasks
@dsnopek dsnopek added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release platform:macos topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@bruvzg @AThousandShips @Repiteo @dsnopek @mhilbrunner