[macOS] Pin Vulkan version in download script #98046
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Oct 10, 2024
There was a problem hiding this comment.
I do not think we want to pin it, SDK distribution format was changed only once since 2021, so it's an extremely rare event.
And doing so will require constantly updating it manually (a new Vulkan SDK is released about every 2 months, and we definitely always want to use the latest version).
That's good to know, I think it makes sense to keep using latest for it then 👍🏼 It also looks like they did it to make cross-platform installation scripts a little easier to do: https://vulkan.lunarg.com/doc/sdk/1.3.296.0/mac/release_notes.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help prevent inconsistent CI results like what happened in the following checks 😄
https://github.com/godotengine/godot/actions/runs/11222724075/job/31195803603?pr=97951
https://github.com/godotengine/godot/actions/runs/11239565581/job/31246955479
The issue was quickly identified in #97981 so builds weren't broken for long thankfully!