Revert "Fix GPUParticles are not rendered for older AMD GPUs with OpenGL+Angle" #98327
+41
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maran23 Could you test this on your device that reproduces #95797 I have just pushed with another commit that removes the polyfill when running with ANGLE based on a comment you made in #95797 (comment). I'm hoping that this will be enough to solve the bug you ran into while still keeping good behaviour on other devices |
|
Thank you for tackling this issue, as I am pretty clueless what to try next. Your idea with the |
|
Tested and it works perfectly fine now. To be sure, we did the following:
|
|
Awesome! Thank you for checking. I'll squash the commits in this PR and then we can merge it. |
…nGL+Angle" This reverts commit 9cc9df5. This also adds a fallback to avoid using the Godot versions of the half 2 float functions when using ANGLE.
clayjohn
force-pushed
the
revert-shader-float
branch
from
07c3544
to
940e9c2
Compare
Maran23
approved these changes
Oct 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96943
Fixes: #97875
This reverts commit 9cc9df5.
Maybe Reintroduces: #95797
We tested #96413 very carefully and Maran23 did a very detailed investigation, but this change has broken more projects than it fixed, so we need to revert for now and try again with something else.