Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use anisotropic filtering to improve texture appearance at oblique angles #181

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 30, 2023

This should only have a small performance impact on dedicated GPUs, as the bottleneck is usually not in texture sampling. On integrated GPUs, the impact is more significant but we'll need a separate preset in the long run anyway. This could ideally be automatically applied with a feature tag provided by the engine once it's implemented.

@Calinou Calinou changed the title Improve particles and VFX, add blob shadow below player and enemies Use anisotropic filtering to improve texture apperance at oblique angles Nov 30, 2023
@Calinou Calinou force-pushed the use-anisotropic-filtering branch 2 times, most recently from b66bb3f to c1f23c1 Compare December 6, 2023 13:55
@akien-mga akien-mga changed the title Use anisotropic filtering to improve texture apperance at oblique angles Use anisotropic filtering to improve texture appearance at oblique angles Dec 6, 2023
@fire
Copy link
Member

fire commented Mar 3, 2024

Test Plan:

Compare a video of the performance enhancement before and after to see what changed.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but trusting that it's a good improvement :)

@akien-mga akien-mga merged commit adc0ec7 into godotengine:master Mar 26, 2024
1 check passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the use-anisotropic-filtering branch March 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants