-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove links to outdated asset library demos #89870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning makes sense to remove. I did not check every single link to see if they're 3.5 though.
These may be outdated on the asset library, but their sources have probably already been updated, see https://github.com/godotengine/godot-demo-projects/. For those projects I think a better approach is to make a new release on the asset library, or link to the source instead. |
I'd say to remove them for now, and then update them, unless we do it very soon, it's been causing a lot of confusion and frustration Though I'd suggest changing these links to point to the demo project repo instead |
I can do a follow-up sweep and add demo links to the repo instead if desired, if not done in this |
Note the asset library is much more accessible than a big GitHub repo, for ordinary users. |
Indeed, meant mainly as a hold-over, as I recall the issue with updating the demos has been the lack of versioning support on the asset library, making it harder to have different versions there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I think.
Alternatively, we could append something like "(3.x)
" to the title of the links. If I was looking for something specific, it may still be useful to know some outdated tutorial is out there as a starting point to adapt from, rather than having nothing. Not sure.
I was planning to upload 4.x demos to the asset library (most demos linked here are already updated in godot-demo-projects' The same goes for the TPS demo, although I wanted to get godotengine/tps-demo#181 merged before I tag a release for it. |
I would argue that we should merge this to be at a good state and then merge in the changes for the new 4.x demos as they complete. |
Do you have any estimate on when they'll be updated in the asset library? |
A few demos aren't uploaded yet as they still need to be updated: godotengine/godot-demo-projects#920 (comment) |
@skyace65 Can you update this PR to point to the new Godot 4 versions of these demos, instead of removing the links? |
Superseded by #90310. |
For future reference, see godotengine/godot-demo-projects#920 (comment). |
Bugsquad edit: superseded by #90310
This removes all links to demo projects in the asset library in the class reference, none of the demos are up to date for 4.x in the class reference, they're all on 3.5. I know there's an argument to be made that people can just convert the projects themselves, but we really shouldn't be asking that of users. I also worry we're wasting users time when they see a link and click on it only to find out it doesn't work for the current version, that doesn't give a great impression of the docs. In addition some of these probably need more thorough changes than others for 4.x like the navigation demos.
Closes godotengine/godot-docs#8055
Closes godotengine/godot-docs#7325
Closes godotengine/godot-docs#7423
Closes godotengine/godot-docs#6055
Closes godotengine/godot-docs#8247
Closes godotengine/godot-docs#7782
Closes godotengine/godot-docs#7000
Closes godotengine/godot-docs#8613