Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Theme demos stopped working for a larger number of themes #412

Closed
Mike-E-angelo opened this issue Aug 24, 2018 · 24 comments
Closed

Theme demos stopped working for a larger number of themes #412

Mike-E-angelo opened this issue Aug 24, 2018 · 24 comments

Comments

@Mike-E-angelo
Copy link

Hello,

Are there known issues with this site? It seems like there are a lot of broken links. Some examples here:
https://themes.gohugo.io/theme/classless-hugo/
https://themes.gohugo.io/theme/hugo-theme-sam/
https://themes.gohugo.io/theme/hugo-icarus/
https://themes.gohugo.io/theme/highlights/
https://themes.gohugo.io/theme/hugo-paper-now/
https://themes.gohugo.io/theme/strata/

I am looking over the open issues and do not see this captured. Sorry if this is already known! Please let me know and I will close if so.

Thank you,
Michael

@digitalcraftsman
Copy link
Member

Hello Michael,

thank you for getting in touch. @onedrawingperday already reported this issue to me earlier this morning. I'll investigate it further in order to find the issue.

@Mike-E-angelo
Copy link
Author

OK cool! Wanted to make sure. :)

@bep
Copy link
Member

bep commented Aug 24, 2018

I suspect that the demo building fails for some (probably good) reason for some themes, and this isn't detected by the script. There is a logic in there to "show the demo button or not".

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Aug 24, 2018

@bep

I cannot pinpoint when the theme demos started to 404.

It seems that affected themes have a naming discrepancy in the config of their Example Sites.

For example a theme called x that resides in a GitHub repository called hugo-x if it is called as theme = "x" in its Example Site’s config then its demo throws a 404 on the website.

That wasn’t the case until recently. Some of the Demos that have the 404 problem were up and running a week ago or something.

@it-gro
Copy link

it-gro commented Aug 25, 2018

My theme did not build (no demo button)
I had:

{{- with $.Site.GetPage `taxonomy` ($.Scratch.Get `theTaxonomy`) (lower ($.Scratch.Get `theTaxTerm`)) }}

in a shortcode
Since v0.45 this was no longer valid.
Fixed that one ...
and run into a canonifyURL issue

(starting from hugo 0.43.0 the .Permalink of an image resource does no longer include BaseURL sub-dirs, if

export HUGO_CANONIFYURLS=true

is given (as in generateThemeSite.sh)

I'm currently prefixing the .RelPermalink with .Site.BaseURL as a workaround
My local tests show, that this will do the trick (hopefully).

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Aug 25, 2018

@it-gro What you mention is different to what this issue is about.
Your theme's demo stopped being published because of .GetPage being re-written.

Also I would suggest that you remove canonifyURLs from your config and use absURL instead in the templates.

This issue is about theme demos going 404 since last week or so.

Thanks.

@it-gro
Copy link

it-gro commented Aug 26, 2018

Looks like starting with 0.42 we see errors if

  1. exampleSite/config.toml theme "ZZZ" does not match the directory name https://github.com/gohugoio/hugoThemes/"ZZZ"
    and either
  2. the exampleSite uses shortcodes
    or
  3. exampleSite does not have the static directory

0.41.* does not show those effects

E.g.:

==== PROCESSING  hugo-theme-sam  ====== 
Building site for theme hugo-theme-sam using its own exampleSite to ../themeSite/static/theme/hugo-theme-sam/
+ env
+ grep HUGO_
HUGO_CANONIFYURLS=true
HUGO_THEMESDIR=/data/scratch/tmp/hugoThemes
+ hugo version
Hugo Static Site Generator v0.42 linux/amd64 BuildDate: 2018-06-12T06:37:22Z
+ pwd
/data/scratch/tmp/hugoThemes/_script/hugoThemeSite
+ hugo -s exampleSite2 -d ../themeSite/static/theme/hugo-theme-sam/ -t hugo-theme-sam -b http://example.com/theme/hugo-theme-sam/
Total in 10 ms
Error: Error copying static files: stat /data/scratch/tmp/hugoThemes/sam/static: no such file or directory
+ set +x
 ==== PROCESSING  hugo-remark-minion  ====== 
Building site for theme hugo-remark-minion using its own exampleSite to ../themeSite/static/theme/hugo-remark-minion/
+ env
+ grep HUGO_
HUGO_CANONIFYURLS=true
HUGO_THEMESDIR=/data/scratch/tmp/hugoThemes
+ hugo version
Hugo Static Site Generator v0.42 linux/amd64 BuildDate: 2018-06-12T06:37:22Z
+ pwd
/data/scratch/tmp/hugoThemes/_script/hugoThemeSite
+ hugo -s exampleSite2 -d ../themeSite/static/theme/hugo-remark-minion/ -t hugo-remark-minion -b http://example.com/theme/hugo-remark-minion/
Building sites … ERROR 2018/08/26 01:45:45 Unable to locate template for shortcode "minion_ooo_left" in page "slide/12.md"
ERROR 2018/08/26 01:45:45 Unable to locate template for shortcode "minion_ooo_left" in page "slide/08.md"
ERROR 2018/08/26 01:45:45 Unable to locate template for shortcode "minion_waaat_right" in page "slide/06.md"
ERROR 2018/08/26 01:45:45 Unable to locate template for shortcode "minion_smile_left" in page "slide/03.md"
ERROR 2018/08/26 01:45:45 Unable to locate template for shortcode "minion_ooo_right" in page "slide/05.md"
ERROR 2018/08/26 01:45:45 Unable to locate template for shortcode "jackie_why" in page "slide/07.md"
Total in 7 ms
Error: Error building site: logged 6 error(s)
+ set +x

https://themes.gohugo.io/hugo-theme-sam/
=> Demo button available - but 404
https://themes.gohugo.io/hugo-remark-minion/
=> Demo button not available

Themes with shortcodes and theme name missmatch
=> no Demo button

Themes without exampleSite/static and theme name missmatch
=> if Demo button is available => 404

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Aug 26, 2018

@it-gro Thank you for spending so much time on this.

The problem that was discovered last week was about:
=> Demo button available - but 404

And the cause is probably as you pointed out:

exampleSite/config.toml theme "ZZZ" does not match the directory name https://github.com/gohugoio/hugoThemes/"ZZZ"

There are also other variations of the above that seem to cause this problem e.g. theme = "../.." in the config of an Example Site.

But as I said above up until last week these Demos were generated despite the above.

(As for the other themes that fail to even have a demo button, it's always been like that. Whenever a Hugo feature gets re-written or deprecated if a theme uses said feature then its demo will not be published)

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Aug 26, 2018

@it-gro

Here is the full list of themes that have a Demo button but are 404.

(I'm posting it in public because there is no need for other people to spend their time making a list that has already been compiled).

https://themes.gohugo.io/hugo-coder/
https://themes.gohugo.io/hugo-theme-massively/
https://themes.gohugo.io/hugo-sodium-theme/
https://themes.gohugo.io/hugo-theme-introduction/
https://themes.gohugo.io/hugo-mdl/
https://themes.gohugo.io/hugo-theme-sam/
https://themes.gohugo.io/hugo-dream-plus/
https://themes.gohugo.io/cocoa-eh-hugo-theme/
https://themes.gohugo.io/hugo-theme-dopetrope/
https://themes.gohugo.io/hugo-theme-nix/
https://themes.gohugo.io/theme/hugo-theme-one/
https://themes.gohugo.io/hugo-resume/
https://themes.gohugo.io/pixyll/
https://themes.gohugo.io/hugo-theme-foundation6/
https://themes.gohugo.io/hugo-theme-zen/
https://themes.gohugo.io/hugo-startpage-theme/
https://themes.gohugo.io/hpstr-hugo-theme/
https://themes.gohugo.io/hugo-theme-vec/
https://themes.gohugo.io/foundation-theme/
https://themes.gohugo.io/manis-hugo-theme/
https://themes.gohugo.io/sublime-hugo-theme/
https://themes.gohugo.io/classless-hugo/
https://themes.gohugo.io/hugo-theme-wave/
https://themes.gohugo.io/highlights/
https://themes.gohugo.io/future-imperfect/
https://themes.gohugo.io/hugo-casper-two/
https://themes.gohugo.io/hugo-kiera/
https://themes.gohugo.io/strata/
https://themes.gohugo.io/type/
https://themes.gohugo.io/hikari/
https://themes.gohugo.io/hugo-minimalist/
https://themes.gohugo.io/hucore/
https://themes.gohugo.io/steam/
https://themes.gohugo.io/hugo-paper-now/
https://themes.gohugo.io/hugo-sp-minimal/
https://themes.gohugo.io/freelancer/
https://themes.gohugo.io/artists/
https://themes.gohugo.io/agency/
https://themes.gohugo.io/cactus/
https://themes.gohugo.io/creative/

So far I have opened the following GitHub Issues to notify authors:
jhu247/minimal-academic#3
panr/hugo-theme-hello-friend#5 [Fixed]

But then I stopped before opening anymore GitHub issues to notify @digitalcraftsman about the problem.

Opening all these issues seems like a pretty time consuming task.

Also it seems that something stopped working on the Hugo Themes Site end.

Maybe this regression can be fixed again and we don't have to make waves notifying all these people.

CC / @bep

@heyarviind
Copy link

is there anything theme developers can do to resolve this issue for their themes?

@onedrawingperday
Copy link
Contributor

@heyarviind

In your Example Site’s config you need to enter theme = "exact-name-of-your-theme-repo"

@heyarviind
Copy link

@onedrawingperday thanks will do it ... :)

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Aug 26, 2018

Thank you @onedrawingperday and @it-gro for compiling this list of themes.

For testing purposes I ran the build script Hugo v0.47.1 and looked at the generated output. A folder for the theme demo is generated and contains, as far as I can tell, all expected files expect the index.html, which is missing in every (sub)directory. Because the demo folder is present we see a demo button, which points to an 404 error page because the index.html is missing.

In order to isolate the issue further I downgraded the Hugo versions (beginning from the latest v0.47.1 release) successively to see when theme demos began to break. I have to note that I do this based on the latest commit at the time of writing.

Hugo version v0.45 and greater showed a demo button but pointed to a 404 error page. v0.42 - v0.44 caused runtime panics which made the whole build fail. Recall that I used the latest commit of this repository which might be incompatible with the state of the repository during the release of Hugo v0.42 - v0.44.

Hugo v0.41 was the first downgraded version that worked fine. v0.41 was released on 25 May. I don't think that an issue that affects so many themes would be unnoticed over months.

I'm not sure if this helps to reason about the cause of this issue. Some of your might be able to reproduce this results.

@it-gro
Copy link

it-gro commented Aug 26, 2018

Hugo v0.41 was the first downgraded version that worked fine.

Yes, I came to the same result (see above)

Looks like starting with 0.42 we see errors if ...
0.41.* does not show those effects

I showed 2 scanarios where we see an issue - there are probably more.
Again the shortcode example:

  1. Take any project using a theme providing some shortcodes (e.g any-cool-theme)
  2. edit the project config.toml
theme = "change_to_anything"
  1. run the project
hugo server -w -t any-cool-theme

In theory the -t argument should (fully) overwrite the theme config in config.toml.
But is does not - since 0.42.0
From this version on we get:

ERROR 2018/08/26 22:25:36 Unable to locate template for shortcode "w3-quote" in page "pages/topics/net/switch.md"
Total in 350 ms
Error: Error building site: logged 178 error(s)
$ echo $?
255

I don't think that an issue that affects so many themes would be unnoticed over months.

Hmm, I didn't spot the missing "Demo" button on my theme page.
Since I have a "Homepage" Button I usually use this one ...

My theme did not build (as I wrote here in the first place) because of the documented breaking changes of .GetPage in 0.45.
There may be other themes affected by this - I see quite a bunch of such errors in the buildTheme output...

@digitalcraftsman digitalcraftsman changed the title Site Healthy? Theme demos stopped working for a larger number of themes Aug 27, 2018
@it-gro
Copy link

it-gro commented Aug 28, 2018

hugo-minimalist-theme config.toml

theme = "hugo-minimalist-theme"

but the directory unter
https://github.com/gohugoio/hugoThemes
is
hugo-minimalist

The generation goes without any error - but with warnings. No layouts are found.

tree _script/hugoThemeSite/themeSite/content/hugo-minimalist/
_script/hugoThemeSite/themeSite/content/hugo-minimalist/
├── index.md
├── screenshot-hugo-minimalist.png
└── tn-featured-hugo-minimalist.png

0 directories, 3 files

No Error => Demo button = yes
But -t $x (directory name) is <> config.toml theme = "directory name"
=> no layouts found => no pages

with debug:

export HUGO_CANONIFYURLS=true
export HUGO_THEMESDIR=/data/scratch/hugoThemes
hugo env
Hugo Static Site Generator v0.47.1/extended linux/amd64 BuildDate: 2018-08-20T08:27:57Z
GOOS="linux"
GOARCH="amd64"
GOVERSION="go1.10.3"

hugo -v --debug -s hugo-minimalist/exampleSite -d _test/ -t hugo-minimalist -b http://localhost:1313/theme/hugo-minimalist/

WARN 2018/08/28 20:51:12 No translation bundle found for default language "en"
WARN 2018/08/28 20:51:12 Translation func for language en not found, use default.
WARN 2018/08/28 20:51:12 i18n not initialized, check that you have language file (in i18n) that matches the site language or the default language.
INFO 2018/08/28 20:51:12 Using config file: /data/2800GB/scratch/hugoThemes/hugo-minimalist/exampleSite/config.toml
Building sites … INFO 2018/08/28 20:51:12 syncing static files to /data/2800GB/scratch/hugoThemes/hugo-minimalist/exampleSite/_test/
INFO 2018/08/28 20:51:12 found taxonomies: map[string]string{"tag":"tags", "category":"categories"}
DEBUG 2018/08/28 20:51:12 Render page to "/post/migrate-from-jekyll/index.html" with layouts ["post/single.en.html.html" "post/single.html.html" "post/single.en.html" "post/single.html" "_default/single.en.html.html" "_default/single.html.html" "_default/single.en.html" "_default/single.html"]
DEBUG 2018/08/28 20:51:12 Render page to "/post/go-is-for-lovers/index.html" with layouts ["post/single.en.html.html" "post/single.html.html" "post/single.en.html" "post/single.html" "_default/single.en.html.html" "_default/single.html.html" "_default/single.en.html" "_default/single.html"]
DEBUG 2018/08/28 20:51:12 Render page to "/post/hugo-is-for-lovers/index.html" with layouts ["post/single.en.html.html" "post/single.html.html" "post/single.en.html" "post/single.html" "_default/single.en.html.html" "_default/single.html.html" "_default/single.en.html" "_default/single.html"]
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "page": [post/single.en.html.html post/single.html.html post/single.en.html post/single.html _default/single.en.html.html _default/single.html.html _default/single.en.html _default/single.html]
DEBUG 2018/08/28 20:51:12 Render page to "/post/creating-a-new-theme/index.html" with layouts ["post/single.en.html.html" "post/single.html.html" "post/single.en.html" "post/single.html" "_default/single.en.html.html" "_default/single.html.html" "_default/single.en.html" "_default/single.html"]
DEBUG 2018/08/28 20:51:12 Render home to "/index.html" with layouts ["page/index.en.html.html" "page/home.en.html.html" "page/list.en.html.html" "page/index.html.html" "page/home.html.html" "page/list.html.html" "page/index.en.html" "page/home.en.html" "page/list.en.html" "page/index.html" "page/home.html" "page/list.html" "index.en.html.html" "home.en.html.html" "list.en.html.html" "index.html.html" "home.html.html" "list.html.html" "index.en.html" "home.en.html" "list.en.html" "index.html" "home.html" "list.html" "_default/index.en.html.html" "_default/home.en.html.html" "_default/list.en.html.html" "_default/index.html.html" "_default/home.html.html" "_default/list.html.html" "_default/index.en.html" "_default/home.en.html" "_default/list.en.html" "_default/index.html" "_default/home.html" "_default/list.html"]
DEBUG 2018/08/28 20:51:12 Render taxonomyTerm to "/categories/index.html" with layouts ["categories/category.terms.en.html.html" "categories/terms.en.html.html" "categories/list.en.html.html" "categories/category.terms.html.html" "categories/terms.html.html" "categories/list.html.html" "categories/category.terms.en.html" "categories/terms.en.html" "categories/list.en.html" "categories/category.terms.html" "categories/terms.html" "categories/list.html" "taxonomy/category.terms.en.html.html" "taxonomy/terms.en.html.html" "taxonomy/list.en.html.html" "taxonomy/category.terms.html.html" "taxonomy/terms.html.html" "taxonomy/list.html.html" "taxonomy/category.terms.en.html" "taxonomy/terms.en.html" "taxonomy/list.en.html" "taxonomy/category.terms.html" "taxonomy/terms.html" "taxonomy/list.html" "category/category.terms.en.html.html" "category/terms.en.html.html" "category/list.en.html.html" "category/category.terms.html.html" "category/terms.html.html" "category/list.html.html" "category/category.terms.en.html" "category/terms.en.html" "category/list.en.html" "category/category.terms.html" "category/terms.html" "category/list.html" "_default/category.terms.en.html.html" "_default/terms.en.html.html" "_default/list.en.html.html" "_default/category.terms.html.html" "_default/terms.html.html" "_default/list.html.html" "_default/category.terms.en.html" "_default/terms.en.html" "_default/list.en.html" "_default/category.terms.html" "_default/terms.html" "_default/list.html"]
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "home": [page/index.en.html.html page/home.en.html.html page/list.en.html.html page/index.html.html page/home.html.html page/list.html.html page/index.en.html page/home.en.html page/list.en.html page/index.html page/home.html page/list.html index.en.html.html home.en.html.html list.en.html.html index.html.html home.html.html list.html.html index.en.html home.en.html list.en.html index.html home.html list.html _default/index.en.html.html _default/home.en.html.html _default/list.en.html.html _default/index.html.html _default/home.html.html _default/list.html.html _default/index.en.html _default/home.en.html _default/list.en.html _default/index.html _default/home.html _default/list.html]
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "taxonomyTerm": [categories/category.terms.en.html.html categories/terms.en.html.html categories/list.en.html.html categories/category.terms.html.html categories/terms.html.html categories/list.html.html categories/category.terms.en.html categories/terms.en.html categories/list.en.html categories/category.terms.html categories/terms.html categories/list.html taxonomy/category.terms.en.html.html taxonomy/terms.en.html.html taxonomy/list.en.html.html taxonomy/category.terms.html.html taxonomy/terms.html.html taxonomy/list.html.html taxonomy/category.terms.en.html taxonomy/terms.en.html taxonomy/list.en.html taxonomy/category.terms.html taxonomy/terms.html taxonomy/list.html category/category.terms.en.html.html category/terms.en.html.html category/list.en.html.html category/category.terms.html.html category/terms.html.html category/list.html.html category/category.terms.en.html category/terms.en.html category/list.en.html category/category.terms.html category/terms.html category/list.html _default/category.terms.en.html.html _default/terms.en.html.html _default/list.en.html.html _default/category.terms.html.html _default/terms.html.html _default/list.html.html _default/category.terms.en.html _default/terms.en.html _default/list.en.html _default/category.terms.html _default/terms.html _default/list.html]
DEBUG 2018/08/28 20:51:12 Render taxonomy to "/tags/jekyll/index.html" with layouts ["tags/tag.en.html.html" "tags/taxonomy.en.html.html" "tags/list.en.html.html" "tags/tag.html.html" "tags/taxonomy.html.html" "tags/list.html.html" "tags/tag.en.html" "tags/taxonomy.en.html" "tags/list.en.html" "tags/tag.html" "tags/taxonomy.html" "tags/list.html" "taxonomy/tag.en.html.html" "taxonomy/taxonomy.en.html.html" "taxonomy/list.en.html.html" "taxonomy/tag.html.html" "taxonomy/taxonomy.html.html" "taxonomy/list.html.html" "taxonomy/tag.en.html" "taxonomy/taxonomy.en.html" "taxonomy/list.en.html" "taxonomy/tag.html" "taxonomy/taxonomy.html" "taxonomy/list.html" "tag/tag.en.html.html" "tag/taxonomy.en.html.html" "tag/list.en.html.html" "tag/tag.html.html" "tag/taxonomy.html.html" "tag/list.html.html" "tag/tag.en.html" "tag/taxonomy.en.html" "tag/list.en.html" "tag/tag.html" "tag/taxonomy.html" "tag/list.html" "_default/tag.en.html.html" "_default/taxonomy.en.html.html" "_default/list.en.html.html" "_default/tag.html.html" "_default/taxonomy.html.html" "_default/list.html.html" "_default/tag.en.html" "_default/taxonomy.en.html" "_default/list.en.html" "_default/tag.html" "_default/taxonomy.html" "_default/list.html"]
DEBUG 2018/08/28 20:51:12 Render taxonomy to "/tags/migration/index.html" with layouts ["tags/tag.en.html.html" "tags/taxonomy.en.html.html" "tags/list.en.html.html" "tags/tag.html.html" "tags/taxonomy.html.html" "tags/list.html.html" "tags/tag.en.html" "tags/taxonomy.en.html" "tags/list.en.html" "tags/tag.html" "tags/taxonomy.html" "tags/list.html" "taxonomy/tag.en.html.html" "taxonomy/taxonomy.en.html.html" "taxonomy/list.en.html.html" "taxonomy/tag.html.html" "taxonomy/taxonomy.html.html" "taxonomy/list.html.html" "taxonomy/tag.en.html" "taxonomy/taxonomy.en.html" "taxonomy/list.en.html" "taxonomy/tag.html" "taxonomy/taxonomy.html" "taxonomy/list.html" "tag/tag.en.html.html" "tag/taxonomy.en.html.html" "tag/list.en.html.html" "tag/tag.html.html" "tag/taxonomy.html.html" "tag/list.html.html" "tag/tag.en.html" "tag/taxonomy.en.html" "tag/list.en.html" "tag/tag.html" "tag/taxonomy.html" "tag/list.html" "_default/tag.en.html.html" "_default/taxonomy.en.html.html" "_default/list.en.html.html" "_default/tag.html.html" "_default/taxonomy.html.html" "_default/list.html.html" "_default/tag.en.html" "_default/taxonomy.en.html" "_default/list.en.html" "_default/tag.html" "_default/taxonomy.html" "_default/list.html"]
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "taxonomy": [tags/tag.en.html.html tags/taxonomy.en.html.html tags/list.en.html.html tags/tag.html.html tags/taxonomy.html.html tags/list.html.html tags/tag.en.html tags/taxonomy.en.html tags/list.en.html tags/tag.html tags/taxonomy.html tags/list.html taxonomy/tag.en.html.html taxonomy/taxonomy.en.html.html taxonomy/list.en.html.html taxonomy/tag.html.html taxonomy/taxonomy.html.html taxonomy/list.html.html taxonomy/tag.en.html taxonomy/taxonomy.en.html taxonomy/list.en.html taxonomy/tag.html taxonomy/taxonomy.html taxonomy/list.html tag/tag.en.html.html tag/taxonomy.en.html.html tag/list.en.html.html tag/tag.html.html tag/taxonomy.html.html tag/list.html.html tag/tag.en.html tag/taxonomy.en.html tag/list.en.html tag/tag.html tag/taxonomy.html tag/list.html _default/tag.en.html.html _default/taxonomy.en.html.html _default/list.en.html.html _default/tag.html.html _default/taxonomy.html.html _default/list.html.html _default/tag.en.html _default/taxonomy.en.html _default/list.en.html _default/tag.html _default/taxonomy.html _default/list.html]
DEBUG 2018/08/28 20:51:12 Render taxonomy to "/tags/hugo/index.html" with layouts ["tags/tag.en.html.html" "tags/taxonomy.en.html.html" "tags/list.en.html.html" "tags/tag.html.html" "tags/taxonomy.html.html" "tags/list.html.html" "tags/tag.en.html" "tags/taxonomy.en.html" "tags/list.en.html" "tags/tag.html" "tags/taxonomy.html" "tags/list.html" "taxonomy/tag.en.html.html" "taxonomy/taxonomy.en.html.html" "taxonomy/list.en.html.html" "taxonomy/tag.html.html" "taxonomy/taxonomy.html.html" "taxonomy/list.html.html" "taxonomy/tag.en.html" "taxonomy/taxonomy.en.html" "taxonomy/list.en.html" "taxonomy/tag.html" "taxonomy/taxonomy.html" "taxonomy/list.html" "tag/tag.en.html.html" "tag/taxonomy.en.html.html" "tag/list.en.html.html" "tag/tag.html.html" "tag/taxonomy.html.html" "tag/list.html.html" "tag/tag.en.html" "tag/taxonomy.en.html" "tag/list.en.html" "tag/tag.html" "tag/taxonomy.html" "tag/list.html" "_default/tag.en.html.html" "_default/taxonomy.en.html.html" "_default/list.en.html.html" "_default/tag.html.html" "_default/taxonomy.html.html" "_default/list.html.html" "_default/tag.en.html" "_default/taxonomy.en.html" "_default/list.en.html" "_default/tag.html" "_default/taxonomy.html" "_default/list.html"]
DEBUG 2018/08/28 20:51:12 Render section to "/post/index.html" with layouts ["post/post.en.html.html" "post/section.en.html.html" "post/list.en.html.html" "post/post.html.html" "post/section.html.html" "post/list.html.html" "post/post.en.html" "post/section.en.html" "post/list.en.html" "post/post.html" "post/section.html" "post/list.html" "section/post.en.html.html" "section/section.en.html.html" "section/list.en.html.html" "section/post.html.html" "section/section.html.html" "section/list.html.html" "section/post.en.html" "section/section.en.html" "section/list.en.html" "section/post.html" "section/section.html" "section/list.html" "_default/post.en.html.html" "_default/section.en.html.html" "_default/list.en.html.html" "_default/post.html.html" "_default/section.html.html" "_default/list.html.html" "_default/post.en.html" "_default/section.en.html" "_default/list.en.html" "_default/post.html" "_default/section.html" "_default/list.html"]
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "section": [post/post.en.html.html post/section.en.html.html post/list.en.html.html post/post.html.html post/section.html.html post/list.html.html post/post.en.html post/section.en.html post/list.en.html post/post.html post/section.html post/list.html section/post.en.html.html section/section.en.html.html section/list.en.html.html section/post.html.html section/section.html.html section/list.html.html section/post.en.html section/section.en.html section/list.en.html section/post.html section/section.html section/list.html _default/post.en.html.html _default/section.en.html.html _default/list.en.html.html _default/post.html.html _default/section.html.html _default/list.html.html _default/post.en.html _default/section.en.html _default/list.en.html _default/post.html _default/section.html _default/list.html]
DEBUG 2018/08/28 20:51:12 Render taxonomyTerm to "/tags/index.html" with layouts ["tags/tag.terms.en.html.html" "tags/terms.en.html.html" "tags/list.en.html.html" "tags/tag.terms.html.html" "tags/terms.html.html" "tags/list.html.html" "tags/tag.terms.en.html" "tags/terms.en.html" "tags/list.en.html" "tags/tag.terms.html" "tags/terms.html" "tags/list.html" "taxonomy/tag.terms.en.html.html" "taxonomy/terms.en.html.html" "taxonomy/list.en.html.html" "taxonomy/tag.terms.html.html" "taxonomy/terms.html.html" "taxonomy/list.html.html" "taxonomy/tag.terms.en.html" "taxonomy/terms.en.html" "taxonomy/list.en.html" "taxonomy/tag.terms.html" "taxonomy/terms.html" "taxonomy/list.html" "tag/tag.terms.en.html.html" "tag/terms.en.html.html" "tag/list.en.html.html" "tag/tag.terms.html.html" "tag/terms.html.html" "tag/list.html.html" "tag/tag.terms.en.html" "tag/terms.en.html" "tag/list.en.html" "tag/tag.terms.html" "tag/terms.html" "tag/list.html" "_default/tag.terms.en.html.html" "_default/terms.en.html.html" "_default/list.en.html.html" "_default/tag.terms.html.html" "_default/terms.html.html" "_default/list.html.html" "_default/tag.terms.en.html" "_default/terms.en.html" "_default/list.en.html" "_default/tag.terms.html" "_default/terms.html" "_default/list.html"]
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "taxonomyTerm": [tags/tag.terms.en.html.html tags/terms.en.html.html tags/list.en.html.html tags/tag.terms.html.html tags/terms.html.html tags/list.html.html tags/tag.terms.en.html tags/terms.en.html tags/list.en.html tags/tag.terms.html tags/terms.html tags/list.html taxonomy/tag.terms.en.html.html taxonomy/terms.en.html.html taxonomy/list.en.html.html taxonomy/tag.terms.html.html taxonomy/terms.html.html taxonomy/list.html.html taxonomy/tag.terms.en.html taxonomy/terms.en.html taxonomy/list.en.html taxonomy/tag.terms.html taxonomy/terms.html taxonomy/list.html tag/tag.terms.en.html.html tag/terms.en.html.html tag/list.en.html.html tag/tag.terms.html.html tag/terms.html.html tag/list.html.html tag/tag.terms.en.html tag/terms.en.html tag/list.en.html tag/tag.terms.html tag/terms.html tag/list.html _default/tag.terms.en.html.html _default/terms.en.html.html _default/list.en.html.html _default/tag.terms.html.html _default/terms.html.html _default/list.html.html _default/tag.terms.en.html _default/terms.en.html _default/list.en.html _default/tag.terms.html _default/terms.html _default/list.html]
DEBUG 2018/08/28 20:51:12 Render XML for "sitemap" to "sitemap.xml"
WARN 2018/08/28 20:51:12 [en] Unable to locate layout for "404": [404.html theme/404.html]
DEBUG 2018/08/28 20:51:12 Render XML for "Categories" to "/categories/index.xml"
DEBUG 2018/08/28 20:51:12 Render XML for "John Doe's blog" to "/index.xml"
DEBUG 2018/08/28 20:51:12 Render XML for "Hugo" to "/tags/hugo/index.xml"
DEBUG 2018/08/28 20:51:12 Render XML for "Jekyll" to "/tags/jekyll/index.xml"
DEBUG 2018/08/28 20:51:12 Render XML for "Migration" to "/tags/migration/index.xml"
DEBUG 2018/08/28 20:51:12 Render XML for "Posts" to "/post/index.xml"
DEBUG 2018/08/28 20:51:12 Render XML for "Tags" to "/tags/index.xml"

                   | EN  
+------------------+----+
  Pages            |  7  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     |  1  
  Processed images |  0  
  Aliases          |  0  
  Sitemaps         |  1  
  Cleaned          |  0  

Total in 13 ms

But no files are created:

ls -lR _test/
_test/:
total 0

Same goes down to version 0.42.0

hugo-0.42.0 -v --debug -s hugo-minimalist/exampleSite -d _test/ -t hugo-minimalist -b http://localhost:1313/theme/hugo-minimalist/
...
                   | EN  
+------------------+----+
  Pages            |  7  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     |  1  
  Processed images |  0  
  Aliases          |  0  
  Sitemaps         |  1  
  Cleaned          |  0  

0.41.0 is fine:

hugo-0.41.0 -v -s hugo-minimalist/exampleSite -d _test/ -t hugo-minimalist -b http://localhost:1313/theme/hugo-minimalist/
INFO 2018/08/28 20:58:30 Using config file: /data/2800GB/scratch/hugoThemes/hugo-minimalist/exampleSite/config.toml
Building sites … INFO 2018/08/28 20:58:30 syncing static files to /data/2800GB/scratch/hugoThemes/hugo-minimalist/exampleSite/_test/
WARN 2018/08/28 20:58:30 No translation bundle found for default language "en"
WARN 2018/08/28 20:58:30 Translation func for language en not found, use default.
WARN 2018/08/28 20:58:30 i18n not initialized, check that you have language file (in i18n) that matches the site language or the default language.
INFO 2018/08/28 20:58:30 found taxonomies: map[string]string{"category":"categories", "tag":"tags"}
INFO 2018/08/28 20:58:30 Alias "/tags/jekyll/page/1/index.html" translated to "tags/jekyll/page/1/index.html"
INFO 2018/08/28 20:58:30 Alias "/tags/hugo/page/1/index.html" translated to "tags/hugo/page/1/index.html"
INFO 2018/08/28 20:58:30 Alias "/tags/migration/page/1/index.html" translated to "tags/migration/page/1/index.html"
INFO 2018/08/28 20:58:30 Alias "/page/1/index.html" translated to "page/1/index.html"
INFO 2018/08/28 20:58:30 Alias "/post/page/1/index.html" translated to "post/page/1/index.html"

                   | EN  
+------------------+----+
  Pages            | 19  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     | 15  
  Processed images |  0  
  Aliases          |  5  
  Sitemaps         |  1  
  Cleaned          |  0  

Total in 45 ms

digitalcraftsman added a commit that referenced this issue Aug 30, 2018
Setting the theme path via the `-t THEME` flag isn't recognized
and still requires to use the HUGO_THEME env variable as workaround.

See #412
See gohugoio/hugo#5061
See gohugoio/hugo#4851
@onedrawingperday
Copy link
Contributor

The themes Hello Friend and Minimal Academic have their demos working again after the GitHub issues I opened.

However I have reason to believe that the 404 issue was caused in Hugo 0.47 and it is related to line 328 of this commit gohugoio/hugo@e5052f4#diff-efb3671b5bf861640622f1c34f07ada9R328

Of course I may be wrong, but in any case I think that you should look into this.

CC / @bep @digitalcraftsman

@funkydan2
Copy link

My Theme Alpha-Church has now got the demo button again, however CSS isn't loading for the demo site. Firefox says it's because the SRI integrity check is failing.

I wonder if this is because the resources folder is committed for both the theme and the demo site. I'm a bit surprised by this - I'm not sure why Hugo is building the resources folder for the demo site when they already exist in the theme folder.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Sep 8, 2018

@funkydan2

I think the above should be posted as a separate issue. This issue is about the 404.

@funkydan2
Copy link

@onedrawingperday thanks, I'll open a new issue.

anthonyfok added a commit that referenced this issue Sep 12, 2018
@digitalcraftsman was trying to re-apply this workaround
in commit 3068f64,
but for some reason that commit contains whitespace cleanup only.
The following commit message was from that commit:

Setting the theme path via the `-t THEME` flag isn't recognized
and still requires to use the HUGO_THEME env variable as workaround.

See #412
See gohugoio/hugo#5061
See gohugoio/hugo#4851

This reverts commit 0b4e98b.
@luizdepra
Copy link

Hey! I'm the hugo-coder author.
I fixed the theme property, as said, to hugo-coder, no only coder. But, no deal.

Can be this an issue with the extended version of Hugo? My theme uses SCSS pipeline.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Sep 14, 2018

Can be this an issue with the extended version of Hugo? My theme uses SCSS pipeline.

@luizdepra Recently we have updated the Theme's repository README please have a look.

Also if in your theme you have a SCSS pipeline, then you need to commit the contents of the /resources/ directory for the Demo to be generated on the website.

Please do the above. And let me know. Thanks.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Sep 14, 2018

@anthonyfok Your commit 3e9282e fixed the demos that were throwing a 404 error on my end. 👍 🥇

@digitalcraftsman This issue can be closed.

P.S. I cannot close this issue myself because I am on the Hugo Web team it seems that this repository belongs to the Hugo Core Team.

@luizdepra
Copy link

@onedrawingperday hmm... I would rather avoid to distribute the resources folder with the theme.
There is a big reason to not build the resources when building the demo site?

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Sep 14, 2018

@luizdepra This is not up for discussion. It is current policy. See:
#404

Your theme was added before Hugo Pipes but there is no way to generate a demo on Netlify without committing the Resources.

Also a theme needs to work even in the Basic version of Hugo. See:
#396 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants